Patch for 64bit build issues

Alex Hudson

2009-02-20 08:45:22 UTC

Post by Andrew Wafaa
I woke up to find a kind chap at SUSE (Philipp Thomas) had responded to
my questions on my packaging issues with a patch to fix 64bit builds.
I'm attaching it for general review etc, and if good enough could we
accept it upstream so to speak?

Well, we're not actually upstream for all these pieces :)

The libical thing needs to be looked at before we kick that on - the
cast to (long) would obviously fix a compile warning. One thing you
might want to check out is whether or not the "upstream" libical is
available in OpenSUSE yet - if so, you can just build Bongo against that
and ignore our internal copy.

The BongoCal stuff - I need to check this against the patch I was
passing around the other day, I think they might be solving the same
issue in different ways. I'll have a look.

ConnIO bits - I think Pat really needs to look at that piece. A double
cast looks wrong to me, though. The socket is defined as an 'int', the
patch casts it to 'long' and gnutls_transport_ptr_t is 'void *'. So, I
don't like it much on that basis - but that's not to say that we
wouldn't accept it.

Thanks for your work on this, much appreciated.

Cheers,

Alex.