Igor Morgado
2009-06-25 18:27:42 UTC
Since bongo-manager is used in startup script I would dare to do some
sugestions.
Why not add an option as -q or --quiet to make bongo-manager behave
more script friendly, a exemple could tell better:
======================
mail:~# /etc/init.d/bongo-manager restart
Restarting Bongo Colaborative Suite: bongo-managerbongo-manager:
Shutting down...
bongo-manager: shutdown complete.
bongo-manager: starting bongostore
version mismatch 0.5.0, 0.5.0rc1ERROR: Unable to find log config
/usr/local/etc/bongo/logs.conf
version mismatch 0.5.0, 0.5.0rc1ERROR: Unable to find log config
/usr/local/etc/bongo/logs.conf
couldn't load config from store
bongo-manager: couldn't read config from store
bongo-manager: Couldn't load configuration for agents
bongo-manager: running in background
======================
I *reallY* dont need all those messages (except my Restarting...
message), everything else should be stripped, I know, I can just
*redirect* the output, but isn't the better way to do it, adding a -q
(quiet) option, is to bongo manager is simple.
Besides that, adding good return values to each status (and document
it), is algo a good idea, since we can handle every exception in
startup scripts (or anywhere else).
BTW, keep the goodwork, and take few less beers before launch releases
from SVN =D
sugestions.
Why not add an option as -q or --quiet to make bongo-manager behave
more script friendly, a exemple could tell better:
======================
mail:~# /etc/init.d/bongo-manager restart
Restarting Bongo Colaborative Suite: bongo-managerbongo-manager:
Shutting down...
bongo-manager: shutdown complete.
bongo-manager: starting bongostore
version mismatch 0.5.0, 0.5.0rc1ERROR: Unable to find log config
/usr/local/etc/bongo/logs.conf
version mismatch 0.5.0, 0.5.0rc1ERROR: Unable to find log config
/usr/local/etc/bongo/logs.conf
couldn't load config from store
bongo-manager: couldn't read config from store
bongo-manager: Couldn't load configuration for agents
bongo-manager: running in background
======================
I *reallY* dont need all those messages (except my Restarting...
message), everything else should be stripped, I know, I can just
*redirect* the output, but isn't the better way to do it, adding a -q
(quiet) option, is to bongo manager is simple.
Besides that, adding good return values to each status (and document
it), is algo a good idea, since we can handle every exception in
startup scripts (or anywhere else).
BTW, keep the goodwork, and take few less beers before launch releases
from SVN =D