Discussion:
memmgr patches
pfelt-Urct4Ww6//Pz1n+
2009-06-15 04:43:25 UTC
Permalink
i've been playing with the memmgr all day today and have crafted a patch
to fix a couple of issues with bongo-config. i still segfault near the
end, but it is a bit late and i need to get to bed. some of the changes
might not be quite right so i thought i'd submit the patch.

cmake/Directories.cmake -> the zoneinfo directory had one to many "bongo"s
in it

include/msgapi.h -> in the code we were XplMutexInit() on a semaphore, and
the init function is looking for a pointer not a pointer to a pointer. i
figured this is what we were really looking for rather than leaving the
header with a XplMutex * and doing the XplMutexInit(var) (since we never
did a malloc on the mutex)

src/apps/config/config.c -> valgrind kept throwing errors in there. it
was actually due to the fact that we could free data, but not reset line
which pointed to data[0]. i added the if() just to be safe.

src/apps/config/CMakeLists.txt -> add the tar command so that we can get
default.set generated and installed. without it bongo-config won't run
right.

src/libs/msgapi/msgdate.c -> my distro didn't have icaltime.h. the
struct in question was defined in ical.h. i'm not sure if this is how
other distro's do it, so this patch is questionable.

hopefully i'll have time to check the logs tomorrow.

Loading...